feat: [ANDROAPP-6780] Add Sdk to aggregate module #3968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Balcan
force-pushed
the
ANDROAPP-6780
branch
2 times, most recently
from
ef8e646 to
160bac3
Compare
andresmr
requested changes
Jan 30, 2025
| .byAttributeOptionComboUid().eq(attrOptionComboUid) | ||
| .blockingGet().map { | ||
| it.toDataSetDetails() | ||
| }.first() |
There was a problem hiding this comment.
Here you are processing the list to then get the first, if the list were bigger than one, it will affect performance, why don't you get the first and the map it?
There was a problem hiding this comment.
Nope, this always returns a 1 item list. I've already asked the sdk to have a more straightfoward way to get the data set instance.
...tes/src/androidMain/kotlin/org/dhis2/mobile/aggregates/data/DataSetInstanceRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
aggregates/src/commonMain/kotlin/org/dhis2/mobile/aggregates/data/DataSetInstanceRepository.kt
Outdated
Show resolved
Hide resolved
xavimolloy
reviewed
Jan 30, 2025
aggregates/src/commonMain/kotlin/org/dhis2/mobile/aggregates/ui/DataSetTableScreen.kt
Show resolved
Hide resolved
aggregates/src/commonMain/kotlin/org/dhis2/mobile/aggregates/ui/DataSetTableScreen.kt
Outdated
Show resolved
Hide resolved
xavimolloy
approved these changes
Jan 30, 2025
ferdyrod
approved these changes
Jan 30, 2025
andresmr
approved these changes
Jan 30, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and include the related jira issue if it exists.
[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-
Solution description
If this PR is a fix include a brief description on how the issue is solved.
Covered unit test cases
Describe the tests that you ran to verify your changes.
Where did you test this issue?
Which Android versions did you test this issue?
Checklist