Task/prefer svgicon in sharing #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edoardo Can you add the new icons to the svgicon example? Also, I know you didn't add the PermissionOption component, but it has no tests and we should try to have some coverage for every component in d2-ui. Could you add tests for it? |
|
@edoardo Regarding prettier, it is not set up in this repo. If you are running prettier in your workspace, it looks like you might need to add a few configurations, like Arrow Function Parentheses, and line width. Here is a link to the options: https://prettier.io/docs/en/options.html |
|
@jenniferarnesen Examples and tests added. |
jenniferarnesen
approved these changes
Jan 4, 2018
edoardo
added a commit
that referenced
this pull request
Jan 4, 2018
This commit includes: * Replace FontIcon with SvgIcon in sharing component, we are moving away from FontIcon * Added tests for PermissionOption component * Some Prettier formatting changes
varl
pushed a commit
that referenced
this pull request
Feb 23, 2018
This commit includes: * Replace FontIcon with SvgIcon in sharing component, we are moving away from FontIcon * Added tests for PermissionOption component * Some Prettier formatting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the SharingDialog component in the new FavoritesDialog component (WIP) and got broken UI due to missing material icons font in my test app.
With nico we decided to use SvgIcon instead.
Replace FontIcon with SvgIcon in the Sharing component.
Added the missing SVG imports in the SvgIcon component.
Sorry for the huge diff, do we have special settings for prettier? I thought we run pretty much with the defaults, but I might have to tweak the settings in my editor.