Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [DHIS2-18737] Scroll to top when navigating in the app #3947

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

chore: [DHIS2-18737] Scroll to top when navigating in the app #3947

wants to merge 21 commits into from
+249 −242

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Jan 23, 2025 •
edited
Loading

DHIS2-18737:

  • Created the useNavigate function.
  • Added the scrollToTop prop, defaulting to true.
  • Replaced direct history.push calls with the hook.

@henrikmv henrikmv removed the testing label Jan 24, 2025
@github-actions GitHub Actions
Copy link

🚀 Deployed on https://deploy-preview-3947.capture.netlify.dhis2.org

@henrikmv henrikmv marked this pull request as ready for review January 25, 2025 12:29
@henrikmv henrikmv requested a review from a team as a code owner January 25, 2025 12:29
simonadomnisoru
simonadomnisoru reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found 2 places left out in EmptyPrograms and OverflowMenu. Could you replace the history there as well? Thanks!

src/core_modules/capture-core/flow/typeDeclarations.js Outdated Show resolved Hide resolved
src/store/getStore.js Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonadomnisoru simonadomnisoru simonadomnisoru left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrikmv @simonadomnisoru