Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [DHIS2-15693] Rules not triggered on program update #3472

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: [DHIS2-15693] Rules not triggered on program update #3472

merged 1 commit into from
Nov 29, 2023
+1 −1

Conversation

eirikhaugstulen
Copy link
Contributor

TECH Summary:

  • Invalidate dataEntryReadyRef if selectedScopeId changes

@eirikhaugstulen eirikhaugstulen marked this pull request as ready for review November 27, 2023 16:49
@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner November 27, 2023 16:49
simonadomnisoru
simonadomnisoru approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link

🚀 Deployed on https://deploy-preview-3472--dhis2-capture.netlify.app

geethaalwan
geethaalwan approved these changes Nov 29, 2023
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.41,2.40.2,2.39.4,2.38.6 versions

@eirikhaugstulen eirikhaugstulen merged commit 2dbca1e into master Nov 29, 2023
@eirikhaugstulen eirikhaugstulen deleted the eh/fix/DHIS2-15693_RunRulesOnProgramUpdate branch November 29, 2023 12:26
dhis2-bot added a commit that referenced this pull request Nov 29, 2023
@dhis2-bot
chore(release): cut 100.45.2 [skip release]
9e60cf7 
## [100.45.2](v100.45.1...v100.45.2) (2023-11-29)

### Bug Fixes

* [DHIS2-15693] Rules not triggered on program update ([#3472](#3472)) ([2dbca1e](2dbca1e))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.45.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonadomnisoru simonadomnisoru

@geethaalwan geethaalwan

Assignees
No one assigned
Labels
released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eirikhaugstulen @dhis2-bot @simonadomnisoru @geethaalwan