fix: [DHIS2-18855] add error logging for program indicators missing e…

…xpressions (#3981)

* fix: add error logging for program indicators missing expressions

* chore: signed commit

.gitignore

@@ -36,3 +36,7 @@ src/locales/
 
 # DHIS2 Platform
 .d2
+
+# Cursor
+.cursorrules
+.cursor

src/core_modules/capture-core/components/WidgetProfile/DataEntry/ProgramRules/rulesContainer.js

@@ -1,4 +1,6 @@
 // @flow
+import log from 'loglevel';
+import { errorCreator } from 'capture-core-utils';
 import type { ProgramRulesContainer } from '@dhis2/rules-engine-javascript';
 import { getTrackedEntityAttributeId, getDataElementId, getProgramId, getProgramRuleActions, getProgramStageId } from '../helpers';
 import { getRulesAndVariablesFromProgramIndicators } from '../../../../metaDataMemoryStoreBuilders/programs/getRulesAndVariablesFromIndicators';
@@ -22,7 +24,22 @@ const addProgramRules = (program, programRules) => {
 };
 
 const addRulesAndVariablesFromProgramIndicators = (program, programIndicators) => {
-    const indicators = programIndicators.map(programIndicator => ({
+    const validProgramIndicators = programIndicators.filter((indicator) => {
+        if (!indicator.expression) {
+            log.error(
+                errorCreator('WidgetProfile: Program indicator is missing an expression and will be skipped.')(
+                    {
+                        method: 'addRulesAndVariablesFromProgramIndicators',
+                        object: indicator,
+                    },
+                ),
+            );
+            return false;
+        }
+        return true;
+    });
+
+    const indicators = validProgramIndicators.map(programIndicator => ({
         ...programIndicator,
         programId: getProgramId(programIndicator),
     }));
@@ -36,6 +53,7 @@ const addRulesAndVariablesFromProgramIndicators = (program, programIndicators) =
     }
 };
 
+
 export const buildRulesContainer = async ({
     programAPI,
     programRules,

src/core_modules/capture-core/metaDataMemoryStoreBuilders/programs/getRulesAndVariablesFromIndicators.js

@@ -1,6 +1,7 @@
 // @flow
 import isString from 'd2-utilizr/lib/isString';
-
+import log from 'loglevel';
+import { errorCreator } from 'capture-core-utils';
 import type { ProgramRule, ProgramRuleAction, ProgramRuleVariable } from '@dhis2/rules-engine-javascript';
 import { variableSourceTypes } from '@dhis2/rules-engine-javascript';
 
@@ -186,7 +187,23 @@ function buildIndicatorRuleAndVariables(programIndicator: CachedProgramIndicator
 export function getRulesAndVariablesFromProgramIndicators(
     cachedProgramIndicators: Array<CachedProgramIndicator>,
     programId: string) {
-    return cachedProgramIndicators
+    // Filter out program indicators without an expression
+    const validProgramIndicators = cachedProgramIndicators.filter((indicator) => {
+        if (!indicator.expression) {
+            log.error(
+                errorCreator('Program indicator is missing an expression and will be skipped.')(
+                    {
+                        method: 'getRulesAndVariablesFromProgramIndicators',
+                        object: indicator,
+                    },
+                ),
+            );
+            return false;
+        }
+        return true;
+    });
+
+    return validProgramIndicators
         .map(programIndicator => buildIndicatorRuleAndVariables(programIndicator, programId))
         .filter(container => container)
         .reduce((accOneLevelContainer, container) => {