Using omniconf in Constants.clj #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 26, 2017 18:28
Uses conf.json location for gcc repo
Contains locations for Github repo locations
Uses repo locations are specified in json.conf
…ectory with spaces.
dgopstein
reviewed
Feb 20, 2017
There was a problem hiding this comment.
All the code looks perfect!
The one thing that will need to change eventually is that your presets are still committed into conf.edn, meaning that this code won't work for me or Henry. I think the right way to handle this is to move your config file to conf.jake.edn, which should be committed, and have no conf.edn committed. Then on your machine you can symlink conf.edn -> conf.jake.edn, and on my machine I can symlink conf.edn -> conf.dan.edn which will also be checked in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the changes. Any comments or questions on my code?