Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes that I think you should know:
[:compare :compare] cases such as
a < b > 1
is now considered not-confusing, mostly due to the false positive case that you sent me. I don't really know any way around it other than this. Plus I think [:compare :compare] has a mixtures of confusing (a <= b != 2
) and not confusing (a == b != 1
) combinations in it. So I don't feel too bad underclassifying this.Any confusing combination involving ternary operator will now only concerns itself with the first operand. So
a && b ? c : d
is considered confusing whilea ? b && c : d
is not.