Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release] add torch button for nightly build #91

Merged
merged 2 commits into from
Apr 16, 2024
Merged

[release] add torch button for nightly build #91

merged 2 commits into from
Apr 16, 2024

Conversation

Rhett-Ying
Copy link
Contributor

Screenshot 2024-04-15 at 11 43 57

@Rhett-Ying Rhett-Ying requested a review from frozenbugs April 15, 2024 03:46
@Rhett-Ying
Copy link
Contributor Author

Don't merge it right now. I will merge it when nightly build is ready

@frozenbugs
Copy link
Contributor

What does it look like if the selected PyTorch version does not match with CUDA?

@Rhett-Ying
Copy link
Contributor Author

image

@frozenbugs
Copy link
Contributor

LGTM

@Rhett-Ying Rhett-Ying merged commit 7a067be into master Apr 16, 2024
@Rhett-Ying
Copy link
Contributor Author

At least one nightly build is ready for now, it's ok to merge it.

@Rhett-Ying Rhett-Ying deleted the torch_split branch April 16, 2024 00:04
@Rhett-Ying
Copy link
Contributor Author

wheel package size comparison: 741.8MB -> 491.3MB

  1. Before torch split which includes torch 2.1.0/1/2, 2.2.0/1, 5 torch versions in total.
    https://data.dgl.ai/wheels-test/cu121/dgl-2.2a240410+cu121-cp39-cp39-manylinux1_x86_64.whl
    741.8MB
  2. After torch split which includes torch 2.1.0/1/2, 3 torch versions in total for torch 2.1.x
    https://data.dgl.ai/wheels-test/torch-2.1/cu121/dgl-2.2a240412+cu121-cp310-cp310-manylinux1_x86_64.whl
    491.3MB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozenbugs frozenbugs frozenbugs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rhett-Ying @frozenbugs