forked from conda-forge/julia-feedstock
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use juliarc #1
Merged
dfornika
merged 4 commits into
dfornika:remove-wrapper-script
from
jakirkham-feedstocks:use_juliarc
Sep 12, 2017
Merged
Use juliarc #1
dfornika
merged 4 commits into
dfornika:remove-wrapper-script
from
jakirkham-feedstocks:use_juliarc
Sep 12, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to ensure packages and other relevant information to the Julia install are tracked in the conda environment.
Make sure that that our custom juliarc is available in the standard location.
Make sure that Julia initializes our package directory and includes the standard packages in it.
Needed to repackage after removal of the wrapper script, inclusion of juliarc, and inclusion of the prepopulated package directory.
jakirkham
pushed a commit
to jakirkham-feedstocks/julia-feedstock
that referenced
this pull request
Sep 13, 2017
* Removed wrapper script * Bumped build number * Use juliarc ( dfornika#1 ) * Add a custom juliarc.jl Needed to ensure packages and other relevant information to the Julia install are tracked in the conda environment. * Install custom juliarc Make sure that that our custom juliarc is available in the standard location. * Create the package directory Make sure that Julia initializes our package directory and includes the standard packages in it. * Bump build number to 1 Needed to repackage after removal of the wrapper script, inclusion of juliarc, and inclusion of the prepopulated package directory. * Removed JULIA_HISTORY setting * Drop package initialization ( dfornika#2 ) This does not work correctly as `conda-build` strips out the `.git` directory from `METADATA`. There are no clean fixes for this issue. As we already try to initialize the package directory when Julia starts, this will be handled anyways on the user's machine. In the end, this may be best to avoid having a potentially out-of-date index in the package. * Append juliarc.jl instead of replace * Append juliarc.jl the right way * Added post-link script for Pkg.init() * Removed Pkg.init() from juliarc.jl * Correct setting Base.LOAD_CACHE_PATH * Correct setting Base.LOAD_CACHE_PATH again (cherry picked from commit 19d96fa)
dfornika
pushed a commit
to conda-forge/julia-feedstock
that referenced
this pull request
Sep 13, 2017
* Removed wrapper script * Bumped build number * Use juliarc ( dfornika#1 ) * Add a custom juliarc.jl Needed to ensure packages and other relevant information to the Julia install are tracked in the conda environment. * Install custom juliarc Make sure that that our custom juliarc is available in the standard location. * Create the package directory Make sure that Julia initializes our package directory and includes the standard packages in it. * Bump build number to 1 Needed to repackage after removal of the wrapper script, inclusion of juliarc, and inclusion of the prepopulated package directory. * Removed JULIA_HISTORY setting * Drop package initialization ( dfornika#2 ) This does not work correctly as `conda-build` strips out the `.git` directory from `METADATA`. There are no clean fixes for this issue. As we already try to initialize the package directory when Julia starts, this will be handled anyways on the user's machine. In the end, this may be best to avoid having a potentially out-of-date index in the package. * Append juliarc.jl instead of replace * Append juliarc.jl the right way * Added post-link script for Pkg.init() * Removed Pkg.init() from juliarc.jl * Correct setting Base.LOAD_CACHE_PATH * Correct setting Base.LOAD_CACHE_PATH again (cherry picked from commit 19d96fa)
jakirkham
pushed a commit
that referenced
this pull request
Sep 13, 2017
* Removed wrapper script * Bumped build number * Use juliarc (#1) * Add a custom juliarc.jl Needed to ensure packages and other relevant information to the Julia install are tracked in the conda environment. * Install custom juliarc Make sure that that our custom juliarc is available in the standard location. * Create the package directory Make sure that Julia initializes our package directory and includes the standard packages in it. * Bump build number to 1 Needed to repackage after removal of the wrapper script, inclusion of juliarc, and inclusion of the prepopulated package directory. * Removed JULIA_HISTORY setting * Drop package initialization (#2) This does not work correctly as `conda-build` strips out the `.git` directory from `METADATA`. There are no clean fixes for this issue. As we already try to initialize the package directory when Julia starts, this will be handled anyways on the user's machine. In the end, this may be best to avoid having a potentially out-of-date index in the package. * Append juliarc.jl instead of replace * Append juliarc.jl the right way * Added post-link script for Pkg.init() * Removed Pkg.init() from juliarc.jl * Correct setting Base.LOAD_CACHE_PATH * Correct setting Base.LOAD_CACHE_PATH again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addendum to PR ( conda-forge#11 ).
juliarc
that fulfills the role the wrapper script did.Draws some inspiration from this SO answer.