Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify audit workflow #3534

Merged
merged 4 commits into from
Jan 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 10 additions & 51 deletions .github/workflows/audit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@ name: Audit
on:
push:
branches:
- master
- main
pull_request:
schedule:
# * is a special character in YAML so you have to quote this string
- cron: "0 14 * * *"

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -13,59 +16,15 @@ concurrency:
env:
# When getting Rust dependencies, retry on network error:
CARGO_NET_RETRY: 10
# Use the local .curlrc
CURL_HOME: .

jobs:
build_matrix:
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
steps:
- uses: actions/checkout@v3
- id: set-matrix
run: echo "matrix=$(scripts/workflows/audit-matrix.py)" >> $GITHUB_OUTPUT

test:
name: audit
runs-on: ${{ matrix.os }}
needs: [ build_matrix ]
strategy:
matrix: ${{fromJson(needs.build_matrix.outputs.matrix)}}

steps:
- uses: actions/checkout@v3
with:
path: sdk
- uses: actions/checkout@v3
with:
repository: 'RustSec/advisory-db'
path: advisory-db
ref: ${{ matrix.advisory-db-rev }}

- uses: actions/cache@v3
with:
path: |
~/.cargo/registry
~/.cargo/git
target
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
- name: Install Rust
run: rustup show
- name: Audit
# ignores RUSTSEC-2020-0071 because it is 'only' in a dev dependency (ic-certified-responses -> ic-types -> chrono -> time)
run: |
cd sdk
cargo audit --no-fetch --db "${GITHUB_WORKSPACE}"/advisory-db --ignore RUSTSEC-2020-0071
env:
RUST_BACKTRACE: 1

aggregate:
name: audit:required
if: ${{ always() }}
needs: test
runs-on: ubuntu-latest
permissions:
contents: read
issues: write

steps:
- name: check step result directly
if: ${{ needs.test.result != 'success' }}
run: exit 1
- uses: actions/checkout@v4
- uses: actions-rust-lang/audit@v1
40 changes: 0 additions & 40 deletions .github/workflows/niv-updater.yml

This file was deleted.

13 changes: 0 additions & 13 deletions nix/sources.json
Original file line number Diff line number Diff line change
@@ -1,17 +1,4 @@
{
"advisory-db": {
"branch": "main",
"builtin": false,
"description": "Security advisory database for Rust crates published through crates.io",
"homepage": "https://rustsec.org",
"owner": "RustSec",
"repo": "advisory-db",
"rev": "fbc3b29acacf335c5fced02566d8f86e59eb1d7a",
"sha256": "1bs2ddk14lsqr9sr1ai7qkszpifaaq81c5b1i3bddi5j7kb43zz6",
"type": "tarball",
"url": "https://github.com/RustSec/advisory-db/archive/fbc3b29acacf335c5fced02566d8f86e59eb1d7a.tar.gz",
"url_template": "https://github.com/<owner>/<repo>/archive/<rev>.tar.gz"
},
"canister_sandbox-x86_64-darwin": {
"builtin": false,
"description": "The canister_sandbox binary. It must be updated together with the replica binary.",
Expand Down
17 changes: 0 additions & 17 deletions scripts/workflows/audit-matrix.py

This file was deleted.

Loading