chore(IDX): clean up status #3942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmattia
force-pushed
the
nm-cleanup-status
branch
from
bc72e6c to
11a58d3
Compare
This removes (more) unused status env vars, and removes the workaround used to clean up the volatile status by instead using stable status for farm metadata. This means farm tests will be retriggered if the jobs are run under a new CI job name, which is actually already the case since ic-os images are not cached (we rely on `diff.sh` for skipping tests).
nmattia
force-pushed
the
nm-cleanup-status
branch
from
11a58d3 to
f041099
Compare
basvandijk
approved these changes
Feb 13, 2025
marko-k0
pushed a commit
that referenced
this pull request
Feb 14, 2025
This removes (more) unused status env vars, and removes the workaround used to clean up the volatile status by instead using stable status for farm metadata. This means farm tests will be retriggered if the jobs are run under a new CI job name, which is actually already the case since ic-os images are not cached (we rely on `diff.sh` for skipping tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes (more) unused status env vars, and removes the workaround used to clean up the volatile status by instead using stable status for farm metadata.
This means farm tests will be retriggered if the jobs are run under a new CI job name, which is actually already the case since ic-os images are not cached (we rely on
diff.shfor skipping tests).