fix(registry): disable replacement of nodes that are active in subnets #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasa-tomic
changed the title
aterga
added
the
CI_ALL_BAZEL_TARGETS
### Summary - Disabled tests related to node replacement in subnet. ### Details - Marked `should_add_node_and_replace_existing_node_in_subnet` as ignored in `do_add_node.rs` pending Consensus team support. - Marked `should_replace_node_in_subnet_and_update_allowance` as ignored in `do_remove_node_directly.rs` pending Consensus team support. ### Additional Changes - Introduced `replacements_of_nodes_in_subnets_enabled` flag set to `false` in `do_remove_node_directly.rs` to conditionally control node replacement logic.
aterga
force-pushed
the
disable-node-subnet-replacement-tests
branch
from
7d4eccf to
8c1e08c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
eichhorl
approved these changes
Feb 13, 2025
aterga
approved these changes
Feb 13, 2025
marko-k0
approved these changes
Feb 13, 2025
basvandijk
approved these changes
Feb 13, 2025
marko-k0
pushed a commit
that referenced
this pull request
Feb 14, 2025
#3935) Direct node replacements of nodes that are active in a subnet may result in unexpected behavior and potential problems in the current Consensus code. So to be on the safe side we need to disable the functionality on the Registry side until the rest of the core protocol can handle it safely. --------- Co-authored-by: CI Automation <[email protected]> Co-authored-by: Arshavir Ter-Gabrielyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct node replacements of nodes that are active in a subnet may result in unexpected behavior and potential problems in the current Consensus code.
So to be on the safe side we need to disable the functionality on the Registry side until the rest of the core protocol can handle it safely.