test: EXC-1878: Add failed stable memory grow tests #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed memory growth operations finish in just a few milliseconds, so 10k seems like a safe assertion.
dragoljub-duric
approved these changes
Feb 13, 2025
|
|
||
| #[test] | ||
| fn failed_stable_memory_grow_cost_and_time_single_canister() { | ||
| const NUM_WASM_PAGES: u64 = 116 * 1024 * MIB / 65_536; |
There was a problem hiding this comment.
Nit: Maybe you can use
ic_replicated_state::canister_state::WASM_PAGE_SIZE_IN_BYTES instead of 65_536. There is as well const GiB. The same applies for the test below
| .build(), | ||
| ); | ||
| let elapsed_ms = timer.elapsed().as_millis(); | ||
| let cycles_m = (initial_balance - env.cycle_balance(canister_id)) / 1000 / 1000; |
There was a problem hiding this comment.
What is the reason for keeping track of spent cycles when they are only used to print messages when a test fails? The same applies to the test below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed memory growth operations finish in just a few milliseconds, so 10k seems like a safe assertion.