fix(ckbtc): use scope guard to prevent double minting #3930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninegua
added
the
CI_OVERRIDE_DIDC_CHECK
ninegua
changed the title
gregorydemay
approved these changes
Feb 13, 2025
marko-k0
pushed a commit
that referenced
this pull request
Feb 14, 2025
XC-254 The loop over processable_utxos may keep looping and eventually panic when exceeding the instruction limit if there is a large number of utxos and all of them have a value less than check_fee. If it does panic, then any previous state modification will not be persisted which spells trouble if a previous utxo has already been minted. Although this is a very unlikely scenario, it does still present a non-zero risk. The fix is to use a scope guard that will be triggered under this situation and update the utxo to a special status to prevent it from being minted again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XC-254
The loop over processable_utxos may keep looping and eventually panic when exceeding the instruction limit if there is a large number of utxos and all of them have a value less than check_fee. If it does panic, then any previous state modification will not be persisted which spells trouble if a previous utxo has already been minted. Although this is a very unlikely scenario, it does still present a non-zero risk.
The fix is to use a scope guard that will be triggered under this situation and update the utxo to a special status to prevent it from being minted again.