Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IDX): Use single BAZEL_COMMAND #3906

Merged
merged 5 commits into from
Feb 13, 2025
Merged

chore(IDX): Use single BAZEL_COMMAND #3906

merged 5 commits into from
Feb 13, 2025

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Feb 11, 2025

This groups all command arguments into a single BAZEL_COMMAND input for the bazel action. This helps clarify which steps build with what flags. BAZEL_TARGETS is also made required to avoid implicit params.

@nmattia nmattia added the CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 label Feb 11, 2025
@github-actions github-actions bot added the chore label Feb 11, 2025
This groups all command arguments into a single `BAZEL_COMMAND` input
for the bazel action. This helps clarify which steps build with what
flags.
@nmattia nmattia marked this pull request as ready for review February 13, 2025 10:41
@nmattia nmattia requested a review from a team as a code owner February 13, 2025 10:41
@github-actions github-actions bot added the @idx label Feb 13, 2025
@nmattia nmattia enabled auto-merge February 13, 2025 10:55
@nmattia nmattia added this pull request to the merge queue Feb 13, 2025
Merged via the queue into master with commit 7e5f934 Feb 13, 2025
27 checks passed
@nmattia nmattia deleted the nm-bzl-cmd branch February 13, 2025 11:25
marko-k0 pushed a commit that referenced this pull request Feb 14, 2025
This groups all command arguments into a single `BAZEL_COMMAND` input
for the bazel action. This helps clarify which steps build with what
flags. `BAZEL_TARGETS` is also made required to avoid implicit params.

---------

Co-authored-by: IDX GitHub Automation <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 @idx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants