Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: synchronize properly with tokio::Notify instead of sleeping #2178

Merged
merged 18 commits into from
Oct 25, 2024
Merged

fix: synchronize properly with tokio::Notify instead of sleeping #2178

merged 18 commits into from
Oct 25, 2024

Conversation

mihailjianu1
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix label Oct 22, 2024
@mihailjianu1 mihailjianu1 marked this pull request as ready for review October 22, 2024 09:30
@mihailjianu1 mihailjianu1 requested a review from a team as a code owner October 22, 2024 09:30
rumenov
rumenov approved these changes Oct 22, 2024
View reviewed changes
rs/bitcoin/adapter/src/router.rs Outdated Show resolved Hide resolved
rs/bitcoin/adapter/src/lib.rs Outdated Show resolved Hide resolved
@DSharifi DSharifi self-requested a review October 22, 2024 11:41
DSharifi
DSharifi reviewed Oct 24, 2024
View reviewed changes
rs/bitcoin/adapter/src/lib.rs Outdated Show resolved Hide resolved
rs/bitcoin/adapter/src/lib.rs Show resolved Hide resolved
rs/bitcoin/adapter/src/lib.rs Outdated Show resolved Hide resolved
rs/bitcoin/adapter/src/lib.rs Outdated Show resolved Hide resolved
@mihailjianu1 mihailjianu1 added this pull request to the merge queue Oct 25, 2024
Merged via the queue into master with commit b56d5e1 Oct 25, 2024
25 checks passed
@mihailjianu1 mihailjianu1 deleted the mihailjianu1-no-sleep branch October 25, 2024 11:33
nmattia pushed a commit that referenced this pull request Oct 25, 2024
@mihailjianu1 @nmattia
fix: synchronize properly with tokio::Notify instead of sleeping (#2178)
7b20c38
@mihailjianu1 mihailjianu1 mentioned this pull request Oct 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 28, 2024
@mihailjianu1
fix: call make_idle if the adapter is idle initially (#2278)
52bc527 
Before #2178, make_idle was called at
server startup if there have been no relevant transactions.

After #2178, make_idle is not called
anymore, meaning that the blockchain_manager and the connection_manager
will stay in a "non idle" state forever for subnets that don't run the
bitcoin adapter.
aterga pushed a commit that referenced this pull request Oct 29, 2024
@mihailjianu1 @aterga
fix: call make_idle if the adapter is idle initially (#2278)
865267d 
Before #2178, make_idle was called at
server startup if there have been no relevant transactions.

After #2178, make_idle is not called
anymore, meaning that the blockchain_manager and the connection_manager
will stay in a "non idle" state forever for subnets that don't run the
bitcoin adapter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumenov rumenov rumenov approved these changes

@DSharifi DSharifi DSharifi approved these changes

Assignees
No one assigned
Labels
fix @networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihailjianu1 @rumenov @DSharifi