EES-5824 handle alt text length error when saving data blocks #5604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyb-hiveit
requested review from
leeoades,
benoutram,
ntsim,
mmoalin,
duncan-at-hiveit,
bennettstuart,
mmyoungman,
rianski,
tomjonesdev and
jack-hive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently editing data blocks that were created before the alt text character limit was added (#5497) can result in an unhandled error when the original alt text was longer than the new limit.
I've improved this by showing an error and telling users to check the Chart configuration:
As part of this I've removed the loading spinner that would show for at least 500ms after the form was submitted as I couldn't find a way to remove it when the form errors. This hopefully won't cause any problems as we have double-submit protection on forms now and don't seem to have performance issues creating / updating data blocks. If this is a problem we may need to reconsider how to handle this error.