EES-5759 handle empty charts #5603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyb-hiveit
requested review from
leeoades,
benoutram,
ntsim,
mmoalin,
duncan-at-hiveit,
bennettstuart,
mmyoungman,
rianski,
tomjonesdev and
jack-hive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously charts with no data would render as an empty white block, which errored on hover. I've changed it to show n message instead:
The change to
CustomTooltip, which was where the original error was, probably isn't necessary as after I added it I changed it so it doesn't try to render empty charts, but I thought I might as well leave it in just in case there are other circumstances in whichpayloadcan be undefined.