feat(helm): push chart to the OCI Registry #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Lamirault <[email protected]>
|
This is a good idea, but I personally do not want to use both the web and registry chart museum. @sagikazarmark what do you think? |
|
I think we should shift towards using OCI. There is also an issue somewhere to move the chart back to the core repo to stay closer with the releases to the main project. I think we should tackle those two together. |
|
OCI is the new norm for Helm charts. What is holding this PR from being reviewed, approved and merged? |
Physics: there are only 24 hours in a day. |
sagikazarmark
requested changes
Jan 13, 2025
| if [ -z "${pkg:-}" ]; then | ||
| break | ||
| fi | ||
| helm push "${pkg}" "oci://ghcr.io/${GITHUB_REPOSITORY_OWNER}/charts" |
There was a problem hiding this comment.
Suggested change
| helm push "${pkg}" "oci://ghcr.io/${GITHUB_REPOSITORY_OWNER}/charts" | |
| helm push "${pkg}" "oci://ghcr.io/${GITHUB_REPOSITORY_OWNER}/helm-charts" |
|
@nabokihms I think we can push to both registries for now and allow a transition period. Once we move the chart back to the Dex repo, we can archive this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What this PR does / why we need it
fix #128
Special notes for your reviewer
Checklist
Chart.yaml(see the contributing guide for details)Chart.yaml(see the contributing guide for details)make docs