New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: set a few components's naming #28

Open

bu-geon wants to merge 2 commits into develop from naming

Collaborator

bu-geon commented Oct 23, 2021 •

edited

Loading

변경 사항

Naming Rule 통일
불필요한 내용 삭제

PR Point

barChart.jsx → BarChart.jsx
shared 디렉토리에 있던 CardHeader를 개별 디렉토리로 뺌(shared 디렉토리 제거)
'PieChart' 디렉토리명 'pieChart'로 변경
CardHeader의 확장자를 js에서 jsx로 변경
package.json에서 사용하지 않는 axios 제거
잘못 추가된 MentionRankCard 컴포넌트 제거

참고 사항

package.json에서 styled-component 아직 살려둠(CardHeader 아직 수정 안함)


          style: set a few components's naming

b62e8dc

bu-geon requested review from Moorisong and devyunja

October 23, 2021 10:13


          style: rename directory from PieChart to pieChart

b5378fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet