Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#914: #940: quickfix to print correct filename #966

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

hohwille
Copy link
Member

fixes #914
fixes #940

Before:

Setting up IDEasy in D:\projects\_ide
IDEasy is already added to your PATH.
Found bash at C:\Program Files\Git\bin\bash.exe
"C:\Program Files\Git\bin\bash.exe" -l -c "cd \"D:\projects\_ide\";./setup"
Setting up IDEasy in /d/projects/_ide
2025.01.001-beta-01_21_02-SNAPSHOT
Created /home/runner/work/IDEasy/IDEasy/cli/pom.xml
Configuring IDEasy in /c/Users/hohwille/.bashrc.
Created /home/runner/work/IDEasy/IDEasy/cli/pom.xml
Configuring IDEasy in /c/Users/hohwille/.zshrc.
ATTENTION: IDEasy has been setup for your shells but you need to start a new shell to make it work.
Only if you invoked this setup script by sourcing it, you are able to run 'ide' and 'icd' commands without starting a new shell.

Setup of IDEasy completed
Drücken Sie eine beliebige Taste . . .

Bug is wrong filename in

Created /home/runner/work/IDEasy/IDEasy/cli/pom.xml

With this fix I get:

Setting up IDEasy in D:\projects\_ide
IDEasy is already added to your PATH.
Found bash at C:\Program Files\Git\bin\bash.exe
"C:\Program Files\Git\bin\bash.exe" -l -c "cd \"D:\projects\_ide\";./setup"
Setting up IDEasy in /d/projects/_ide
2025.01.001-beta-01_21_02-SNAPSHOT
Created /c/Users/hohwille/.bashrc
Configuring IDEasy in /c/Users/hohwille/.bashrc.
Created /c/Users/hohwille/.zshrc
Configuring IDEasy in /c/Users/hohwille/.zshrc.
ATTENTION: IDEasy has been setup for your shells but you need to start a new shell to make it work.
Only if you invoked this setup script by sourcing it, you are able to run 'ide' and 'icd' commands without starting a new shell.

Setup of IDEasy completed
Drücken Sie eine beliebige Taste . . .

Only problem: I have no clue why the error happened before...
The adding of curly braces should not be the reason.
So renaming of the local variable did fix it???

@hohwille hohwille added this to the release:2025.01.001 milestone Jan 21, 2025
@hohwille hohwille self-assigned this Jan 21, 2025
@hohwille hohwille added bugfix bash install installation process of IDE + tools and install commandlet labels Jan 21, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12884518210

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.126%

Totals Coverage Status
Change from base Build 12884436096: 0.0%
Covered Lines: 7080
Relevant Lines: 10016

💛 - Coveralls

@hohwille hohwille merged commit 5bd98cc into devonfw:main Jan 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash bugfix install installation process of IDE + tools and install commandlet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Setup needs to create .bashrc if not existent
2 participants