#43: implement xml merger #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9600435990Details
💛 - Coveralls |
hohwille
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
@salimbouch thanks for your PR. You took a very complex story and created a very impressive result for it. Awesome job 🥇
In our review meeting, we created issue #403 for the findings to improve.
But since your implementation already works very nice and solves everything except some edge-cases, I will merge this as is so we can already benefit from this great work in our team and in the next releases 👍
For #403 you can already start creating a new PR based on this work and apply the refactorings and improvements.
Therefore I will now merge this PR.
hohwille
added
the
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43