Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ACT, finalize FRD implementation, fix Mii struct #558

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ZeroSkill1
Copy link
Contributor

  • Implemented the entirety of the friends services commands, fixing incorrect ones and adding all the missing ones.
  • Fix up the existing base Mii struct.

@TuxSH
Copy link
Collaborator

TuxSH commented Mar 6, 2025

Looks good, though, could you give more context on why you added PACKED?

@ZeroSkill1
Copy link
Contributor Author

The MiiData struct as it was before was too large. Furthermore, the bitfields weren't padded properly and thus caused extraneous padding bytes to be inserted in between the inner structs. The MiiData struct must be exactly 0x5C in size (and it wasn't before). Both friends and ACT assume this base struct to be exactly 0x5C in size.

@fincs
Copy link
Member

fincs commented Mar 6, 2025

Some of the changes add PACKED to structures that only contain 8-bit members. Why is that?

@ZeroSkill1
Copy link
Contributor Author

That must've been an oversight from when I was trying to fix up the incorrect alignments. I've removed CTR_PACKED from the inner structs that don't need it.

@ZeroSkill1 ZeroSkill1 changed the title Finalize the implementation for Friends services, fix Mii struct Implement ACT, finalize FRD implementation, fix Mii struct Mar 7, 2025
@ZeroSkill1
Copy link
Contributor Author

While I'm at it, I'm also going to add the implementation for ACT services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants