Skip to content

Commit

Permalink
add env var for arm64 support and update docs
Browse files Browse the repository at this point in the history
Signed-off-by: Jordan Dubrick <[email protected]>
  • Loading branch information
Jdubrick committed Nov 30, 2023
1 parent b3fe21e commit 7941330
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
4 changes: 4 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,7 @@ Owners of the repository will watch out for and review new PRs.
If comments have been given in a review, they have to be addressed before merging.

After addressing review comments, don’t forget to add a comment in the PR afterward, so everyone gets notified by Github and knows to re-review.

## Troubleshooting

- There is a known issue with Apple Silicon (arm64) architectures that may cause the `build_viewer.sh` script to fail. If this issue occurs first run `export PLATFORM_EV=linux/arm64`.
8 changes: 0 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,5 @@
"typescript": "^4.9.3",
"url-loader": "^4.1.1",
"webpack": "^5.76.0"
},
"overrides": {
"@nrwl/workspace": {
"@parcel/watcher": "2.1.0"
},
"@nx": {
"@parcel/watcher": "2.1.0"
}
}
}
3 changes: 2 additions & 1 deletion scripts/build_viewer.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@ set -eux

ABSOLUTE_PATH="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
BUILD_DIR=$ABSOLUTE_PATH/..
PLATFORM_EV=${PLATFORM_EV:-"linux/amd64"}

# Set Docker/Podman alias if necessary
. ${ABSOLUTE_PATH}/setenv.sh

docker build --no-cache -t registry-viewer $BUILD_DIR \
docker build --platform ${PLATFORM_EV} --no-cache -t registry-viewer $BUILD_DIR \
--build-arg PROJECT_NAME=registry-viewer \
--build-arg NEXT_PUBLIC_BASE_PATH=${NEXT_PUBLIC_BASE_PATH:-"/viewer"}

0 comments on commit 7941330

Please sign in to comment.