chore!: remove stac record creation #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ciaran Sweet <[email protected]>
j08lue
approved these changes
Dec 13, 2024
|
For the record - we are planning to still have a mechanism to create STAC records from OS-C Hazard output, but do that in a post-processing script instead. We are planning on taking the same approach for generating Xarray / data cube friendly Zarr output - remove that from this code base and do it in post-processing. We can reference the scripts once they are ready, in case someone else needs this. |
ciaransweet
added a commit
that referenced
this pull request
Dec 16, 2024
* chore!: remove stac as inventory format Signed-off-by: Ciaran Sweet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR is
This PR removes STAC Record creation as an option/implementation
This was added via DevSeed and I think we're the only people who were using it, it's not optimal and we're likely not going to rely on this method further.
Removing reduces any potential maintainance overhead.
How I did it
stacrelated implementations where it comes to inventory writingCWLto remove the option to choose the inventory styleHow you can test it
You can remove the
inventory_formatoption for local runs and you'll see you only get aninventory.jsonfile now(Though CEDA FTP is dead right now so I can't actually test this :'( )