Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try wheel build with manylinux auto #226

Closed
wants to merge 1 commit into from
Closed

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Feb 5, 2025

Counterpart to #225

In the log output of #225, I see

📦 Wheel is eligible for a higher priority tag. You requested manylinux_2_24 but this wheel is eligible for manylinux_2_17 (aka manylinux2014)

I think setting manylinux: auto in CI will fail because of our ring dependency, but let's double check.

Let's test this on CI: https://github.com/developmentseed/obstore/actions/runs/13167021669/job/36749471672

@kylebarron
Copy link
Member Author

kylebarron commented Feb 5, 2025

Ok I can confirm that this does fail:

warning: [email protected]: In file included from /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ring-0.17.8/pregenerated/aesv8-armx-linux64.S:4:0:
warning: [email protected]: include/ring-core/asm_base.h:73:2: error: #error "ARM assembler must define __ARM_ARCH"
warning: [email protected]:  #error "ARM assembler must define __ARM_ARCH"
warning: [email protected]:   ^
warning: [email protected]: In file included from /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ring-0.17.8/pregenerated/aesv8-armx-linux64.S:7:0:
warning: [email protected]: include/ring-core/arm_arch.h:82:2: error: #error "ARM assembler must define __ARM_ARCH"
warning: [email protected]:  #error "ARM assembler must define __ARM_ARCH"
warning: [email protected]:   ^
error: failed to run custom build command for `ring v0.17.8`
Caused by:
  process didn't exit successfully: `/home/runner/work/obstore/obstore/target/release/build/ring-5e586e57a4eda826/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=RING_PREGENERATE_ASM
  cargo:rustc-env=RING_CORE_PREFIX=ring_core_0_17_8_
  OPT_LEVEL = Some(3)
  TARGET = Some(aarch64-unknown-linux-gnu)
  OUT_DIR = Some(/home/runner/work/obstore/obstore/target/aarch64-unknown-linux-gnu/release/build/ring-4335b30f21830[552](https://github.com/developmentseed/obstore/actions/runs/13167021669/job/36749471672#step:5:559)/out)
  HOST = Some(x86_64-unknown-linux-gnu)
  cargo:rerun-if-env-changed=CC_aarch64-unknown-linux-gnu
  CC_aarch64-unknown-linux-gnu = None
  cargo:rerun-if-env-changed=CC_aarch64_unknown_linux_gnu
  CC_aarch64_unknown_linux_gnu = Some(aarch64-unknown-linux-gnu-gcc)
  cargo:rerun-if-env-changed=CC_KNOWN_WRAPPER_CUSTOM
  CC_KNOWN_WRAPPER_CUSTOM = None
  RUSTC_WRAPPER = Some(sccache)
  cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some(false)
  CARGO_CFG_TARGET_FEATURE = Some(neon)
  cargo:rerun-if-env-changed=CFLAGS_aarch64-unknown-linux-gnu
  CFLAGS_aarch64-unknown-linux-gnu = None
  cargo:rerun-if-env-changed=CFLAGS_aarch64_unknown_linux_gnu
  CFLAGS_aarch64_unknown_linux_gnu = None
  cargo:rerun-if-env-changed=TARGET_CFLAGS
  TARGET_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  cargo:warning=In file included from /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ring-0.17.8/pregenerated/aesv8-armx-linux64.S:4:0:
  cargo:warning=include/ring-core/asm_base.h:73:2: error: #error "ARM assembler must define __ARM_ARCH"
  cargo:warning= #error "ARM assembler must define __ARM_ARCH"
  cargo:warning=  ^
  cargo:warning=In file included from /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ring-0.17.8/pregenerated/aesv8-armx-linux64.S:7:0:
  cargo:warning=include/ring-core/arm_arch.h:82:2: error: #error "ARM assembler must define __ARM_ARCH"
  cargo:warning= #error "ARM assembler must define __ARM_ARCH"
  cargo:warning=  ^
  --- stderr
  error occurred: Command "sccache" "aarch64-unknown-linux-gnu-gcc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-I" "include" "-I" "/home/runner/work/obstore/obstore/target/aarch64-unknown-linux-gnu/release/build/ring-4335b30f21830552/out" "-Wall" "-Wextra" "-fvisibility=hidden" "-std=c1x" "-Wall" "-Wbad-function-cast" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wnested-externs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wstrict-prototypes" "-Wundef" "-Wuninitialized" "-g3" "-DNDEBUG" "-o" "/home/runner/work/obstore/obstore/target/aarch64-unknown-linux-gnu/release/build/ring-4335b30f21830552/out/ca5a6bd8bd60c5f6-aesv8-armx-linux64.o" "-c" "/root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ring-0.17.8/pregenerated/aesv8-armx-linux64.S" with args aarch64-unknown-linux-gnu-gcc did not execute successfully (status code exit status: 1).
warning: build failed, waiting for other jobs to finish...
💥 maturin failed
  Caused by: Failed to build a native library through cargo
  Caused by: Cargo build finished with "exit status: 101": `env -u CARGO PYO3_CONFIG_FILE="/home/runner/work/obstore/obstore/target/maturin/pyo3-config-aarch64-unknown-linux-gnu-3.9.txt" "cargo" "rustc" "--features" "pyo3/extension-module" "--target" "aarch64-unknown-linux-gnu" "--message-format" "json-render-diagnostics" "--manifest-path" "/home/runner/work/obstore/obstore/obstore/Cargo.toml" "--release" "--lib" "--" "-C" "strip=symbols"`
Error: The process '/usr/bin/docker' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1702:25)
    at ExecState.CheckComplete (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1685:18)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1[579](https://github.com/developmentseed/obstore/actions/runs/13167021669/job/36749471672#step:5:586):27)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)
Error: The process '/usr/bin/docker' failed with exit code 1

@kylebarron kylebarron closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant