-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #171 - remove warnings about deprecated hook on react 16.9.0^ #172
Conversation
Very nice ;) |
Co-Authored-By: Jason Miller <[email protected]>
Hi! Can this be merged, or is there any other thing to adjust? :) |
@Akiyamka hello stranger. i opened a couple of pull requests with rather substantial changes that i personally think greatly improves unistore and was looking for some feedback on. i'm assuming @developit is busy and meanwhile i was hoping to get this feedback from elsewhere. since you have opened a pull request yourself i assume you are familiar with the package and would love to hear what you think about the changes i propose. you can find them at #182 and #183. the second one builds upon the changes from the first. |
@developit Any chance this could be merged? :) |
@hesselbom ooh, that's quite the intrusive warning. I'll try to get this merged and cut a release today. |
@developit it was very simple to rewrite the react integration to use hooks instead and the size shrunk considerably. i have a WIP at #186 |
Published as 3.5.2. |
This will fix issue with warnings.
Probably will be better migrate to getDerivedStateFromProps hook with null return, but I not sure how I can call static method it this case