-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : 예약과 회원 연관관계 매핑 #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로직 구현하느라 고생 많으셨습니다! MemberReservationControllerTest
참고해 기존 컨트롤러 테스트 수정하겠습니다!
@@ -157,9 +167,11 @@ void getAllReservation() { | |||
@Test | |||
@DisplayName("예약 내역이 하나도 없을 시 조회되는 예약이 없다.") | |||
void getAllReservationWithNoResult() { | |||
when(reservationRepository.findAllWithReservationTimeAndShop()).thenReturn(List.of()); | |||
Member member = MemberFixture.member("[email protected]"); | |||
when(reservationRepository.findAllWithReservationTimeAndShopByMemberId(member)).thenReturn( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
email을 따로 상수로 빼도 좋을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오우..!! 추가된 작업이 반복된 작업이라 귀찮으실수도 있었을텐데 고생하셨습니다~
close #64
⛏ 작업 상세 내용
📝 작업 요약
☑️ 중점적으로 리뷰 할 부분