Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature : owner 웨이팅 조회 API 구현 #75
feature : owner 웨이팅 조회 API 구현 #75
Changes from 15 commits
d041146
a6a50b2
e647fdc
6ab5e4e
edab978
e1017f0
d0694f5
f494bcd
46ace9b
7c4962f
2ca04c6
2f5829b
7afb52a
f18dbdc
c2eb81e
5cdfadc
ec30c7c
08da5a3
5344cf7
c747742
0939180
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr에 rank순으로 정렬해서 가져온다했는데 그게 이 부분인가요?? 정렬은 안 보이고 reverse()만 보여서요.. 몰라서 질문드립니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵! 리스트에 데이터 삽입 시 왼쪽으로 계속 삽입되기 때문에 rank가 큰 순으로 waitingId가 정렬되어 있습니다.
이를 reverse()로 rank가 작은 순으로 정렬해 반환하는 로직입니다.
ex: [3L, 2L, 1L] -> [1L, 2L, 3L]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기서 쿼리가 한방 더 나갈거같아요..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
owner.getShop().getId() 부분 말씀하시는건가요? 현재 임시로만 ownerId를 받는거라서 fetch join은 구현하지 않았습니다!