Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : 대기 취소, 대기 조회 API 구현 #70

Merged
merged 20 commits into from
Jan 7, 2024
Merged

feat : 대기 취소, 대기 조회 API 구현 #70

merged 20 commits into from
Jan 7, 2024

Conversation

hyun2371
Copy link
Member

@hyun2371 hyun2371 commented Jan 6, 2024 •
edited
Loading

⛏ 작업 상세 내용

  • response 필드에 웨이팅 상태 추가
    • 변경에 따른 테스트 코드 수정
  • 엔티티에 상태 변경 로직 추가
  • 성공, 실패에 대한 통합 테스트 작성
  • repository waiting 조회함수에 진행 중 상태 추가

📝 작업 요약

  • 대기 취소 API 구현
  • 대기 취소 통합 테스트, 단위 테스트 작성
  • 대기 조회 API 구현
  • 대기 조회 통합 테스트, 단위 테스트 작성

☑️ 중점적으로 리뷰 할 부분

  • 비즈니스 로직
  • 누락된 테스트 없는지

@hyun2371 hyun2371 self-assigned this Jan 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024 •
edited
Loading

Test Results

69 tests  +4   69 ✅ +4   21s ⏱️ -1s
20 suites ±0    0 💤 ±0 
20 files   ±0    0 ❌ ±0 

Results for commit dc95bcb. ± Comparison against base commit 46c57c7.

♻️ This comment has been updated with latest results.

dlswns2480
dlswns2480 approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@dlswns2480 dlswns2480 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@hyun2371 hyun2371 changed the title feat : 대기 취소 API 구현 feat : 대기 취소, 대기 조회 API 구현 Jan 7, 2024
@hyun2371 hyun2371 force-pushed the feat/#67/waiting-cancel-api branch from 3e8ca95 to dc95bcb Compare January 7, 2024 08:29
@hyun2371 hyun2371 merged commit 5779770 into dev Jan 7, 2024
3 checks passed
@hyun2371 hyun2371 deleted the feat/#67/waiting-cancel-api branch January 8, 2024 14:25
@hyun2371 hyun2371 linked an issue Jan 17, 2024 that may be closed by this pull request
feature : 대기 취소, 조회 API 구현 #67
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlswns2480 dlswns2480 dlswns2480 approved these changes

@kkangh00n kkangh00n Awaiting requested review from kkangh00n

Assignees

@hyun2371 hyun2371

Labels
feature
Projects
Catch Table
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature : 대기 취소, 조회 API 구현
2 participants
@hyun2371 @dlswns2480