Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : 예약 dto mapper 수정 #114

Merged
merged 4 commits into from
Jan 18, 2024
Merged

feat : 예약 dto mapper 수정 #114

merged 4 commits into from
Jan 18, 2024

Conversation

dlswns2480
Copy link
Member

⛏ 작업 상세 내용

  • close feature : 예약 등록, 수정 응답 dto 필드 교체 #113

  • 전에 mapper에서 응답 dto로 변환할 때 회원이름에 예시데이터인 "memberA"로 설정되어 있어 예약한 회원의 이름을 넣어주는 것으로 변경

  • 예약 가져오는 쿼리에 회원도 페치조인 추가

  • 이에 따른 테스트 코드 전부 수정

📝 작업 요약

  • mapper 및 쿼리 수정

☑️ 중점적으로 리뷰 할 부분

  • 테스트 코드는 안 보셔도 됩니다. 수정한 부분에 대해서만 테스트 코드 수정해서 mapper랑 쿼리만 리뷰 부탁~

@dlswns2480 dlswns2480 self-assigned this Jan 17, 2024
Copy link

Test Results

130 tests  ±0   127 ✅ ±0   8s ⏱️ ±0s
 34 suites ±0     3 💤 ±0 
 34 files   ±0     0 ❌ ±0 

Results for commit 77636fc. ± Comparison against base commit c2d194a.

Copy link
Member

@hyun2371 hyun2371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

�mapper랑 쿼리 수정하느라 고생 많으셨습니다!

Copy link
Collaborator

@kkangh00n kkangh00n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시연 전 테스트 안해봤으면 큰일날뻔했네요... 고생하셨습니다~!~!

@dlswns2480 dlswns2480 merged commit 4c4b6c7 into dev Jan 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants