-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Integration tests #158
[Test] Integration tests #158
Conversation
Codecov Report
@@ Coverage Diff @@
## development #158 +/- ##
===============================================
+ Coverage 14.23% 19.38% +5.15%
===============================================
Files 42 45 +3
Lines 2958 2992 +34
===============================================
+ Hits 421 580 +159
+ Misses 2537 2412 -125
Continue to review full report at Codecov.
|
@prasadtalasila any solution to codeclimate issue for now? Because we need all 5 param for testing it. I think refactoring work can be done later. |
@@ -70,8 +74,8 @@ def author_interaction(): | |||
json_data[json_obj['Message-ID']] = json_obj | |||
print("JSON data loaded.") | |||
else: | |||
lone_author_threads = get_lone_author_threads(False) | |||
with open('clean_data.json', 'r') as json_file: | |||
lone_author_threads = get_lone_author_threads(nodelist_filename=graph_nodes, edgelist_filename=graph_edges) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use positional arguments here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_lone_author_threads()
is a function of read.py, which was to be refactored afterward.
@@ -0,0 +1,279 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
short test data files are preferable to long ones. If you can reduce the number of entries in this file and still have the test coverage, that would be a good thing.
Data input size reduced for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hrishikesh-dahiya one minor change in the sphinx docs
:param graph_nodes: Path to graph_nodes.csv file | ||
:param graph_edges: Path to graph_edges.csv file | ||
:param pajek_file: Path to author_graph.net(pajek file) which is used by write_to_pajek() | ||
:param ignore_lat: True | ||
""" | ||
# Time limit can be specified here in the form of a timestamp in one of the identifiable formats and all messages | ||
# that have arrived after this timestamp will be ignored. | ||
time_limit = None | ||
# If true, then messages that belong to threads that have only a single author are ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move this description to sphinx docs of ignore_lat
variable.
Description
generate.py
,keyword_clustering.py
,data_cleanup.py
Motivation
Types of changes
Checks
Fixes #152 and #155
if relevantNotify reviewers
@prasadtalasila