Use modern openssl functions #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BN_is_prime_ex is deprecated in OpenSSL 3.0, and all OpenSSL versions lesser than 3.0 are deprecated as well. Use BN_check_prime according to the migration guide (https://docs.openssl.org/3.0/man7/migration_guide/).
SHA* functions are deprecated in OpenSSL 3.0 and adviced to replace with EVP api in migration guide (https://docs.openssl.org/3.0/man7/migration_guide/). Also, using generic EVP api allows us to clean up code a bit.
|
|
EVP_DigestFinal is deprecated according to OpenSSL 3.0 documentation
Otherwise such call makes no sense, and result of EVP_DigestFinal_ex is undefined.
cnt0
force-pushed
the
fix-cmake-deprecations
branch
from
0ed7d19 to
f844b9b
Compare
|
Conclusions from the group discussion:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I replaced some functions which are declared as deprecated in OpenSSL 3.0 (cause it's a minimum supported version nowadays) as per its migration guide. This allows to fix some build warnings (I noticed quite a lot of such warnings in telegram codebase BTW).
Also, happy new year!