FGR: account for cumulative delays ≥20 minutes #116
Conversation
date calculation was off, fix whitespace and use consistent wording
…e if used for fgr
|
i noticed that it didn't actually account for train cancellations followed by a substitute connection yet, so i added that as well. it gets displayed like this: this PR doesn't touch the normal FGR view and all changes are exclusively in the cumulative view but i can convert the normal page to the departureboard style list too at a later point if so desired :) |
* add a tiny arrow to better communicate travel direction * the destination bubble is now a "check", as in check-out * the train origin is now an empty bublbe * cancelled train stops are set in italics
|
ok as what i hope is the final touch this time, the view now also includes missed connections like the regular FGR page: i've also added some visual restyling of the route history that hopefully better indicates that the direction of travel is "upwards": i applied the same formatting to the |
|
Hey, |
|
I have seen the PR, appreciate it, and will not provide a time frame. It's fairly certain that I'll review and merge it eventually. travelynx is a hobby project which I work on whenever and wherever I feel like, and I find it healthy to take that hobby aspect seriously. Sorry about that ;) |
|
Not setting a timeframe is fully okay of course. Appreciate hearing back from you anyway, thanks! |
|
Just a quick heads up: Still no ETA for this, sorry. I'm slowly getting back to computer touching, at least. |
This is a quick workaround until I have finally reviewed #116
|
Kein Stress ^^ |
Because metronom's reliability is approaching an area where actually getting compensation for a 49 euro ticket starts becoming feasible month-for-month by me, i've decided to implement #73:
in the FGR page there's now an explanation and link to the new cumulative delays subpage:
there's a progress bar on how much delays you have to "earn" to get at least some of your money back, and a list of offending trains with FGR form download links:
you can select which ticket (for which timeframe) you're using, which will change the projected reimbursement. selecting a regional ticket excludes long-distance trains.
this is my first contribution where i actually touched the perl code a bit. i do not know perl! the code might be awful and not idiomatic. i apologize in advance for that specifically.
have a nice weekend! 🧡