DN-4: Sending post path in query param since it was thinking it was a…

…n end point.
dereckmezquita · Jul 15, 2024 · 7c9f4fd · 7c9f4fd
1 parent 7bb24ed
commit 7c9f4fd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/client/src/app/test/api/demos/comments/CommentsDemo.tsx b/client/src/app/test/api/demos/comments/CommentsDemo.tsx
@@ -45,7 +45,7 @@ export function CommentsDemo() {
         try {
             const encodedPathname = encodeURIComponent(pathname);
             const response = await api.get<CommentsResponse>(
-                `/comments/${encodedPathname}?page=${page}&limit=10`
+                `/comments?post=${encodedPathname}&page=${page}&limit=10`
             );
             setComments((prevComments) => [
                 ...prevComments,

diff --git a/server/src/routes/comments/comments.ts b/server/src/routes/comments/comments.ts
@@ -6,9 +6,12 @@ const router = express.Router();
 /**
  * Allows fetching top-level comments and replies
  */
-router.get('/comments/:post', async (req: Request, res: Response) => {
-    const { post } = req.params;
-    const { depth = 1, limit = 10, page = 1 } = req.query;
+router.get('/comments', async (req: Request, res: Response) => {
+    const { post, depth = 1, limit = 10, page = 1 } = req.query;
+
+    if (!post || typeof post !== 'string') {
+        return res.status(400).json({ message: 'Post parameter is required' });
+    }
 
     const decodedPost = decodeURIComponent(post);