Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): synced disabled and error states for select #1342

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

orest-s
Copy link
Contributor

@orest-s orest-s commented Feb 9, 2024

Closes: #1006

@orest-s orest-s requested a review from a team as a code owner February 9, 2024 17:49
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1342.d15792l1n26ww3.amplifyapp.com

Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this file hasn't been touched in a while and has some old patterns, but our new guidelines specify these should be component level variables.

example:

:root {
  --select-background-color-disabled: var(--field-background-color-disabled)
}

.cauldron--theme-light {
  --select-background-color-disabled: /* whatever color is supposed to be here */
}

.Field__select--disabled select {
  background: var(--select-background-color-disabled);
}
...

It's okay if this takes a little more time since we're trying to align our component css patterns as well.

packages/styles/select.css Outdated Show resolved Hide resolved
@scurker scurker changed the title fix(styles): synced disabled and error states for select feat(styles): synced disabled and error states for select May 8, 2024
@scurker scurker dismissed their stale review May 8, 2024 20:15

dismissing review, updated pr myself

box-shadow: rgba(0, 0, 0, 0.05) 0 1px 2px 0 inset,
var(--field-border-color-error-focus-glow) 0 0 4px 0;
var(--select-field-border-color-error) 0 0 0 1px,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done after a discussion with @dequelabs/cauldron-design in which we decided a temporary solution to address an a11y issue would be to increase the size of the focus ring upon focus.

@scurker scurker requested review from a team May 8, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync Select with UXPin
2 participants