[feat] : 내 Gallery 등록 기능 추가 #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dojinyou
reviewed
Feb 26, 2024
Comment on lines
16
to
21
| }.recoverCatching { | ||
| when(it is OptimisticLockingFailureException) { | ||
| true -> listenBookmarked(targetId) | ||
| false -> throw it | ||
| } | ||
| } |
There was a problem hiding this comment.
데이터 싱크 맞추려면 무조건 성공해야해서 횟수제한 안넣었어
jitter방식으로 몇초 대기하고 재실행하는 로직 넣어야할듯?
일단 비동기(클라이언트가계속대기할수도있으니까) + 랜덤대기로 구현하는방향으로 수정했어
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
어떤 기능을 개발했나요?
내 Gallery 등록 기능을 추가했습니다.
어떻게 해결했나요?
이슈 넘버
참고자료