Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#1/kakao social login setting #8

Merged
merged 8 commits into from
Jul 4, 2024
+49 −0
Merged

Feature/#1/kakao social login setting #8

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d665de5
feat: kakaoLogin template 생성
sean2337 Jul 1, 2024
8c14a40
feat: kakao login Redirection 로직 생성
sean2337 Jul 1, 2024
ee80b4d
Merge branch 'depromeet:main' into feature/#1/kakao-socialLogin_setting
sean2337 Jul 2, 2024
7c62d45
chore: #1 modify kakao social key name
sean2337 Jul 3, 2024
5fe51e7
chore: #1 modify backend url name
sean2337 Jul 3, 2024
5bd87fe
refactor: #1 Axios 인터셉터 정의 활용
sean2337 Jul 3, 2024
d87b6ff
chore: 소셜 로그인 데이터 타입에 대한 주석 추가
sean2337 Jul 3, 2024
88bb6dd
chore: 코드 간결성을 위한 type 제거
sean2337 Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: #1 modify backend url name
@sean2337
sean2337 committed Jul 3, 2024
commit 5fe51e7ac7adaf9eedbe16ede15833cb1630d7b2
2 changes: 1 addition & 1 deletion src/app/login/KakaoLoginRedirection.tsx
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ const KaKaoRedirection = () => {
useEffect(() => {
// // FIXME: 백엔드 API에 따라 주소 수정 필요
axios
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 부분은 Axios 인터셉터에 정의되어있는 api로 호출해서 쓰면 좋을 것 같아요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 코드 확인하고 수정하겠습니다!

.post(`${import.meta.env.REACT_APP_URL}kakaoLogin${code}`)
.post(`${import.meta.env.VITE_API_URL}kakaoLogin${code}`)
.then((r) => {
console.log(r.data);
// FIXME: 받은걸 어디에 저장할지 논의 필요 (로그인 저장 방식에 따라 달리짐)

Unchanged files with check annotations Beta

View file
src/app/MainPage.tsx
import { messageAtom } from "@/store/messageAtom.tsx";
function MainPage() {
const [message, setMessage] = useAtom(messageAtom);

Check failure on line 7 in src/app/MainPage.tsx

GitHub Actions / build 

'setMessage' is declared but its value is never read.
return (
<div>
<span>welcome to layer 🎇</span>