Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input, TextArea 글자 수 카운트 추가 #47

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Input, TextArea 글자 수 카운트 추가 #47

merged 7 commits into from
Jul 18, 2024

Conversation

leeminhee119
Copy link
Member

@leeminhee119 leeminhee119 commented Jul 17, 2024 •
edited
Loading

Input, TextArea 글자 수 카운트 추가

🏄🏼‍♂️‍ Summary (요약)

  • TextArea 컴포넌트 추가
    • Input과 동일하게 사용하시면 됩니다. (훅도 동일하게 useInput 사용)
  • 글자 수 세는 기능 추가
    • maxLength, count 전달

🫨 Describe your Change (변경사항)

  • src/component/common/input/Input.tsx
  • src/component/common/input/TextArea.tsx
  • src/hooks/useInput.ts

🧐 Issue number and link (참고)

📚 Reference (참조)

스크린샷 2024-07-17 오후 10 45 13

@leeminhee119 leeminhee119 added the 🚀 feature New feature or request label Jul 17, 2024
@leeminhee119 leeminhee119 added this to the v1.0.0 milestone Jul 17, 2024
@leeminhee119 leeminhee119 self-assigned this Jul 17, 2024
klmhyeonwoo
klmhyeonwoo approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@klmhyeonwoo klmhyeonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

알잘딱깔센 ✨

donghunee
donghunee approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@donghunee donghunee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 미쳤다.. 굿굿👍👍

@leeminhee119 leeminhee119 force-pushed the refactor/11/input-validation branch from f7d4569 to aeb44f0 Compare July 18, 2024 03:59
@leeminhee119 leeminhee119 merged commit 83013e0 into develop Jul 18, 2024
1 check passed
@leeminhee119 leeminhee119 deleted the refactor/11/input-validation branch July 18, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klmhyeonwoo klmhyeonwoo klmhyeonwoo approved these changes

@donghunee donghunee donghunee approved these changes

@sean2337 sean2337 Awaiting requested review from sean2337

Assignees

@leeminhee119 leeminhee119

Labels
🚀 feature New feature or request
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@leeminhee119 @klmhyeonwoo @donghunee