홈페이지 개발 #45
Merged
홈페이지 개발 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
donghunee,
klmhyeonwoo and
leeminhee119
Closed
11 tasks
leeminhee119
approved these changes
Jul 17, 2024
src/app/home/HomePage.tsx
Outdated
Comment on lines
25
to
27
| const GoMakeReview = () => { | ||
| navigate("/review"); | ||
| }; |
src/layout/DefaultLayout.tsx
Outdated
| import { AppBar, AppBarProps } from "@/component/common/appBar"; | ||
|
|
||
| type DefaultLayoutProps = AppBarProps & { | ||
| appBarVisible?: boolean; | ||
| theme?: string; |
There was a problem hiding this comment.
개인적인 의견인데, 요거 theme을 유니온으로 지정하고 각 타입에 따라 컴포넌트 내부에서 색상을 지정해주는 건 어떨까요 ?? 배경 색 종류가 몇개 없어서, default 등 이름으로 지정해주면 편할 것 같아요!
klmhyeonwoo
reviewed
Jul 18, 2024
| width: 100%; | ||
| height: 7.4rem; | ||
| background-color: #ffffff; | ||
| box-shadow: 0.4rem, #2125290a; |
There was a problem hiding this comment.
제가 잘 몰라서 그러는데 #2125290a는 뭐예요?!
klmhyeonwoo
reviewed
Jul 18, 2024
| @@ -8,7 +8,7 @@ type TypographyProps = { | |||
| as?: Extract<React.ElementType, TextTags>; | |||
| variant?: keyof typeof DESIGN_SYSTEM_TEXT; | |||
| color?: keyof typeof DESIGN_SYSTEM_COLOR; | |||
| children: string; | |||
| children: React.ReactElement | string; | |||
There was a problem hiding this comment.
이거 혹시 슬랙 참고하셔서 타입 수정 가능하실까요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏄🏼♂️ Summary (요약)
🫨 Describe your Change (변경사항)
🧐 Issue number and link (참고)
📚 Reference (참조)