Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

컨벤션에 따른 재정의 #39

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

sean2337
Copy link
Collaborator

@sean2337 sean2337 commented Jul 15, 2024

컴포넌트 컨벤션에 따른 구조 정의


🏄🏼‍♂️‍ Summary (요약)

컴포넌트 컨벤션에 따른 구조 정의에 따라 파일구조를 재변경했습니다.

🫨 Describe your Change (변경사항)

공용 컴포넌트의 경우 index.ts는 단순한 export의 역할을 하도록 하고, 컴포넌트 파일에서 정의 한후 index.js에서 export하도록 수정했습니다.

🧐 Issue number and link (참고)

📚 Reference (참조)

@sean2337 sean2337 changed the title Refactor/28/convention refactor 컨벤션에 따른 재정의 Jul 15, 2024
@sean2337 sean2337 added the 🧹 refactor 사용자에게는 드러나지 않는 코드 상의 변화 label Jul 15, 2024
@sean2337 sean2337 added this to the v1.0.0 milestone Jul 15, 2024
Copy link
Member

@klmhyeonwoo klmhyeonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨👀

Copy link
Collaborator

@donghunee donghunee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 👍👍

@sean2337 sean2337 merged commit 9751c72 into develop Jul 15, 2024
2 checks passed
@sean2337 sean2337 deleted the refactor/28/convention-refactor branch July 15, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 refactor 사용자에게는 드러나지 않는 코드 상의 변화
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants