Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes [weekly 1.5k] [composer] Helper-Subprocess-Errors #11495

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Feb 5, 2025

What are you trying to accomplish?

Adds error handlers for various composer errors including private source authentication failures, i_nvalid requirements_ in manifest files, and bad response errors.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Feb 5, 2025
@github-actions github-actions bot added the L: php:composer Issues and code for Composer label Feb 5, 2025
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/composer-dependabot-sharedhelpers-helpersubprocessfailed branch 3 times, most recently from da28d87 to b20bd6c Compare February 5, 2025 19:16
@sachin-sandhu sachin-sandhu marked this pull request as ready for review February 5, 2025 19:20
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner February 5, 2025 19:20
Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachin-sandhu sachin-sandhu force-pushed the ssandhu/composer-dependabot-sharedhelpers-helpersubprocessfailed branch from b20bd6c to 04d45ad Compare February 5, 2025 19:49
@sachin-sandhu sachin-sandhu merged commit 01e8554 into main Feb 5, 2025
55 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/composer-dependabot-sharedhelpers-helpersubprocessfailed branch February 5, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: php:composer Issues and code for Composer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants