Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run PNPM install for catalogs rather than update #11454

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

robaiken
Copy link
Contributor

@robaiken robaiken commented Jan 31, 2025

What are you trying to accomplish?

When updating PNPM workspace catalogs, we need to use pnpm install to update the lockfile instead of pnpm update. This ensures proper handling of workspace dependencies when making catalog-wide updates.

Anything you want to highlight for special attention from reviewers?

This approach ensures that workspace updates use the correct PNPM command while maintaining existing behavior for regular package updates.

How will you know you've accomplished your goal?

  1. Running pnpm update in a workspace project - should correctly update the lockfile using install
  2. Running pnpm update in a regular project - should use the normal update+install flow
  3. Checking that lockfiles are generated correctly in both scenarios

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@robaiken robaiken added the L: javascript:pnpm npm packages via pnpm label Jan 31, 2025
@robaiken robaiken marked this pull request as ready for review January 31, 2025 14:00
@robaiken robaiken requested a review from a team as a code owner January 31, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants