Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds handler for workspace with no path specified #11405

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Jan 25, 2025

What are you trying to accomplish?

Adds handler for exception when a include path folder name is not specified in a workspace.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Jan 25, 2025
@github-actions github-actions bot added the L: rust:cargo Rust crates via cargo label Jan 25, 2025
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/cargo-type-error branch from 1000580 to dc1978a Compare January 27, 2025 13:43
@sachin-sandhu sachin-sandhu marked this pull request as ready for review January 27, 2025 13:44
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner January 27, 2025 13:44
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/cargo-type-error branch from dc1978a to efaa1a8 Compare January 27, 2025 14:45
markhallen and others added 18 commits January 31, 2025 10:38
* Fix detection of `npm_and_yarn` engines
* Add `constraint_helper` to validate constraints based on SemVer specifications
* Enhance version selector to address engine constraint issues using `constraint_helper`

---------

Co-authored-by: kbukum1 <[email protected]>
* terraform: skip support files during parsing
* add spec for checking skip of support file

---------

Co-authored-by: kbukum1 <[email protected]>
…1431)

* Adds error handler for registry errors

* Update maven/lib/dependabot/maven/update_checker/version_finder.rb

Co-authored-by: Mark Allen <[email protected]>

---------

Co-authored-by: Mark Allen <[email protected]>
* adding pnpm catalog protocol support

* adding feature flag

* fixing lint for yaml file

* adding catalog experiment to tests

* adding pnpm_workspace method to get workspace file

* removing exception

* adding sorbet typing

* disabling class length cop

* moving yarn workspace fixture to pnpm

* Adding tests cases to file parser and updater

* adding typing to enable_pnpm_workspace_catalog?

* fixing test fixtures

* lint

* moving rubocop disable

* removing unneeded imports

added create_workspace_dependency

* refactoring `create_dependency` function
…rror (#11438)

* Raise DependencyFileUnsupported error when API returns matching error

* Fix flaky tests that fail every time the versions on the container are updated

* Rubocop line length fix
* Updating type to strict.

* Checking without update

* Updating type to strong.

* Updating type to strict.

* Testing without changes

* Testing with type check.

---------

Co-authored-by: “Thavachelvam <“[email protected]”>
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner January 31, 2025 15:39
@github-actions github-actions bot added L: ruby:bundler RubyGems via bundler L: terraform Terraform packages L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet labels Jan 31, 2025
@brettfo
Copy link
Contributor

brettfo commented Feb 5, 2025

This includes some NuGet changes that have already been merged, I think you'll need to rebase to get those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: devcontainers L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet L: java:maven Maven packages via Maven L: javascript L: python L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo L: terraform Terraform packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.