Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sorbettype check as strict #11379

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

randhircs
Copy link
Member

@randhircs randhircs commented Jan 22, 2025

What are you trying to accomplish?

Added sorbettype check as strict for python/lib/dependabot/python/file_parser/pipfile_files_parser.rb

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

It should pass all the test cases and post deployment it should not break.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@randhircs randhircs requested a review from a team as a code owner January 22, 2025 18:53
@randhircs randhircs marked this pull request as draft January 22, 2025 18:54
@randhircs randhircs self-assigned this Jan 22, 2025
@randhircs randhircs marked this pull request as ready for review January 22, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant