Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip catalog protocol when using directory configuration in monorepos #11361

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

robaiken
Copy link
Contributor

What are you trying to accomplish?

When updating individual repositories within a monorepo using the directory configuration, we want to skip the catalog: protocol. This change improves the handling of monorepo dependency updates by ensuring Dependabot correctly processes directory-specific updates without being affected by the catalog protocol.

Anything you want to highlight for special attention from reviewers?

The main change focuses on the protocol handling logic. I chose to skip the catalog protocol specifically for directory updates since these are meant to operate on isolated parts of the repository, and the catalog protocol isn't necessary in this context. This approach ensures clean, targeted updates for individual packages within monorepos.

How will you know you've accomplished your goal?

Users can successfully process updates for specific directories in their monorepo. The "no change" errors previously triggered by catalog versions no longer block these updates

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@robaiken robaiken marked this pull request as ready for review January 21, 2025 16:42
@robaiken robaiken requested a review from a team as a code owner January 21, 2025 16:42
@robaiken robaiken merged commit 46fcd61 into main Jan 21, 2025
68 checks passed
@robaiken robaiken deleted the robaiken/skip-pnpm-catalog-protocol-dependencies branch January 21, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants