Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run full updater on all dependencies, including transitives #11255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Jan 9, 2025

This PR only updates the end-to-end NuGet updater which is not yet used in production.

It allows updates to happen on both top-level and transitive dependencies. The result is a scenario that the hybrid Ruby/C# updater can't handle, but the end-to-end updater can.

The test has a dependency reported from three locations:

  1. As a top-level dependency - up to date.
  2. As a top-level dependency - needs update.
  3. As a transitive dependency - needs pinning.

The hybrid updater can only update scenario 2 and misses the transitive dependency.

@brettfo brettfo requested a review from a team as a code owner January 9, 2025 00:48
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant