Remove Hex Jason dependency (#11295)

JSON now ships with Elixir 1.18, which means that the Elixir portion of the Hex processing can now remove Jason, and have no dependencies. This simplifies some uncommon (to most) mix environment setup that adds some friction to onboarding. Co-authored-by: Hariharan Thavachelvam <[email protected]>
dependabot · Jan 22, 2025 · 83b4d5d · 83b4d5d
1 parent fb8ba72
commit 83b4d5d
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 49 deletions.
diff --git a/hex/helpers/build b/hex/helpers/build
@@ -26,7 +26,5 @@ esac
 
 cp $CP_OPTS "$helpers_dir/lib" "$install_dir"
 cp $CP_OPTS "$helpers_dir/mix.exs" "$install_dir"
-cp $CP_OPTS "$helpers_dir/mix.lock" "$install_dir"
 
 cd "$install_dir"
-mix deps.get
diff --git a/hex/helpers/lib/do_update.exs b/hex/helpers/lib/do_update.exs
@@ -10,21 +10,13 @@ dependency =
 {dependency_lock, rest_lock} = Map.split(Mix.Dep.Lock.read(), [dependency])
 Mix.Dep.Fetcher.by_name([dependency], dependency_lock, rest_lock, [])
 
-System.cmd(
-  "mix",
-  [
-    "deps.get",
-    "--no-compile",
-    "--no-elixir-version-check",
-  ],
-  [
-    env: %{
-      "MIX_EXS" => nil,
-      "MIX_LOCK" => nil,
-      "MIX_DEPS" => nil
-    }
-  ]
-)
+args = [
+  "deps.get",
+  "--no-compile",
+  "--no-elixir-version-check",
+]
+
+System.cmd("mix", args, [env: %{"MIX_EXS" => nil}])
 
 "mix.lock"
 |> File.read()

diff --git a/hex/helpers/lib/run.exs b/hex/helpers/lib/run.exs
@@ -1,7 +1,7 @@
 defmodule DependencyHelper do
   def main() do
     IO.read(:stdio, :eof)
-    |> Jason.decode!()
+    |> JSON.decode!()
     |> run()
     |> case do
       {output, 0} ->
@@ -35,7 +35,7 @@ defmodule DependencyHelper do
 
   defp encode_and_write(content) do
     content
-    |> Jason.encode!()
+    |> JSON.encode!()
     |> IO.write()
   end
 
@@ -69,16 +69,7 @@ defmodule DependencyHelper do
         script
       ] ++ args
 
-    System.cmd(
-      "mix",
-      args,
-      cd: dir,
-      env: %{
-        "MIX_EXS" => nil,
-        "MIX_LOCK" => nil,
-        "MIX_DEPS" => nil
-      }
-    )
+    System.cmd("mix", args, cd: dir, env: %{"MIX_EXS" => nil})
   end
 
   defp set_credentials([]), do: :ok

diff --git a/hex/helpers/mix.exs b/hex/helpers/mix.exs
@@ -2,20 +2,16 @@ defmodule DependabotCore.Mixfile do
   use Mix.Project
 
   def project do
-    [app: :dependabot_core,
-     version: "0.1.0",
-     elixir: "~> 1.5",
-     start_permanent: Mix.env == :prod,
-     lockfile: System.get_env("MIX_LOCK") || "mix.lock",
-     deps_path: System.get_env("MIX_DEPS") || "deps",
-     deps: deps()]
+    [
+      app: :dependabot_core,
+      version: "0.1.0",
+      elixir: "~> 1.18",
+      start_permanent: Mix.env == :prod,
+      deps: []
+    ]
   end
 
   def application do
     [extra_applications: [:hex, :logger, :ssh]]
   end
-
-  defp deps() do
-    [{:jason, "~> 1.0"}]
-  end
 end
diff --git a/hex/helpers/mix.lock b/hex/helpers/mix.lock
diff --git a/hex/lib/dependabot/hex/file_parser.rb b/hex/lib/dependabot/hex/file_parser.rb
@@ -117,8 +117,6 @@ def sanitize_mixfile(content)
       def mix_env
         {
           "MIX_EXS" => File.join(NativeHelpers.hex_helpers_dir, "mix.exs"),
-          "MIX_LOCK" => File.join(NativeHelpers.hex_helpers_dir, "mix.lock"),
-          "MIX_DEPS" => File.join(NativeHelpers.hex_helpers_dir, "deps"),
           "MIX_QUIET" => "1"
         }
       end

diff --git a/hex/lib/dependabot/hex/file_updater/lockfile_updater.rb b/hex/lib/dependabot/hex/file_updater/lockfile_updater.rb
@@ -114,8 +114,6 @@ def sanitize_mixfile(content)
         def mix_env
           {
             "MIX_EXS" => File.join(NativeHelpers.hex_helpers_dir, "mix.exs"),
-            "MIX_LOCK" => File.join(NativeHelpers.hex_helpers_dir, "mix.lock"),
-            "MIX_DEPS" => File.join(NativeHelpers.hex_helpers_dir, "deps"),
             "MIX_QUIET" => "1"
           }
         end

diff --git a/hex/lib/dependabot/hex/update_checker/version_resolver.rb b/hex/lib/dependabot/hex/update_checker/version_resolver.rb
@@ -167,8 +167,6 @@ def version_class
         def mix_env
           {
             "MIX_EXS" => File.join(NativeHelpers.hex_helpers_dir, "mix.exs"),
-            "MIX_LOCK" => File.join(NativeHelpers.hex_helpers_dir, "mix.lock"),
-            "MIX_DEPS" => File.join(NativeHelpers.hex_helpers_dir, "deps"),
             "MIX_QUIET" => "1"
           }
         end