Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10-10EZ | Upgrade performance for presubmit components #35117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

longmd
Copy link
Contributor

@longmd longmd commented Mar 7, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

With one of OCTOs key goals in 2025 being to improve overall performance on VA.gov, the 10-10 team is doing an audit our own products to ensure we are as performant as can be. This PR performs some basic modifications for readability and performance to the pre-submit components for the review page.

Related issue(s)

department-of-veterans-affairs/va.gov-team#103774

Acceptance criteria

  • Component is as performant as possible in all environments.

Quality Assurance & Testing

  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors
  • Events are being sent to the appropriate logging solution

Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

Copy link
Contributor

@coope93 coope93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants