-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAGOV-TEAM-103554: View-form page #20710
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a2b7098
Adds route for view-form page.
ryguyk afdd9ae
- Adds theme entries for view-form page.
ryguyk 50b8879
- Updates controller methods to align with refactored themes.
ryguyk 5459b3d
- Creates `base` directory for parent page-content templates.
ryguyk 5ccc471
Updates tests to align with new button ids.
ryguyk f9145e6
Adds functional test for view-form page.
ryguyk c2357f1
Changes "one-column-with-buttons" to "single-column-with-buttons".
ryguyk 9dce8ad
Adds library/css for single-column-with-buttons pages.
ryguyk b6cc6ad
Updates controller tests to add test for viewForm method.
ryguyk 720df89
- Removes unnecessary prefixes on libraries.
ryguyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
3 changes: 3 additions & 0 deletions
3
docroot/modules/custom/va_gov_form_builder/css/single-column-with-buttons.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.form-builder-single-column-with-buttons__main-content > p { | ||
margin-bottom: var(--units-3); | ||
} |
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
docroot/modules/custom/va_gov_form_builder/templates/page-content/address-info.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{% extends '@va_gov_form_builder/page-content/base/non-editable-pattern.html.twig' %} | ||
|
||
{% set page_id = 'address-info' %} | ||
{% set page_heading = 'Collecting address information' %} | ||
{% set step_label = 'Address information' %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
...stom/va_gov_form_builder/templates/page-content/base/single-column-with-buttons.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
<div id="form-builder-content-{{ page_id }}" class="form-builder-content form-builder-single-column-content form-builder-page-content form-builder-content--single-column-with-buttons"> | ||
<h2 class="form-builder-page-title">{{ page_heading }}</h2> | ||
|
||
{% if block('main_content') is not empty %} | ||
<div class="form-builder-single-column-with-buttons__main-content"> | ||
{% block main_content %}{% endblock %} | ||
</div> | ||
{% endif %} | ||
|
||
<section class="form-builder-button-group"> | ||
{% if buttons.secondary is defined %} | ||
{% for secondary_button in buttons.secondary %} | ||
<a | ||
id="form-builder-secondary-button-{{loop.index}}" | ||
href="{{ secondary_button.url }}" | ||
role="button" | ||
class="form-builder-button form-builder-button--secondary" | ||
> | ||
{{ secondary_button.label }} | ||
</a> | ||
{% endfor %} | ||
{% endif %} | ||
{% if buttons.primary is defined %} | ||
<a | ||
id="form-builder-primary-button" | ||
href="{{ buttons.primary.url }}" | ||
role="button" | ||
class="form-builder-button form-builder-button--primary" | ||
> | ||
{{ buttons.primary.label }} | ||
</a> | ||
{% endif %} | ||
</section> | ||
</div> |
5 changes: 5 additions & 0 deletions
5
docroot/modules/custom/va_gov_form_builder/templates/page-content/contact-info.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{% extends '@va_gov_form_builder/page-content/base/non-editable-pattern.html.twig' %} | ||
|
||
{% set page_id = 'contact-info' %} | ||
{% set page_heading = 'Collecting contact information' %} | ||
{% set step_label = 'Contact information' %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,4 @@ | |
{% endfor %} | ||
</ul> | ||
</section> | ||
|
||
|
||
</div> |
16 changes: 16 additions & 0 deletions
16
...t/modules/custom/va_gov_form_builder/templates/page-content/identification-info.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{% extends '@va_gov_form_builder/page-content/base/non-editable-pattern.html.twig' %} | ||
|
||
{% set page_id = 'identification-info' %} | ||
{% set page_heading = 'Collecting identifying information' %} | ||
{% set step_label = 'Your personal information' %} | ||
|
||
{% block step_description %} | ||
<p> | ||
<strong>Note:</strong> Below is the default pattern for asking a submitter for this information. | ||
Some forms may ask for other types of information. The guidance for this item can be found | ||
here: | ||
<a href="https://design.va.gov/patterns/ask-users-for/social-security-number#examples"> | ||
https://design.va.gov/patterns/ask-users-for/social-security-number#examples | ||
</a> | ||
</p> | ||
{% endblock %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
docroot/modules/custom/va_gov_form_builder/templates/page-content/name-and-dob.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{% extends '@va_gov_form_builder/page-content/base/non-editable-pattern.html.twig' %} | ||
|
||
{% set page_id = 'name-and-dob' %} | ||
{% set page_heading = 'Collecting Name and Date of birth' %} | ||
{% set step_label = 'Your personal information' %} |
7 changes: 0 additions & 7 deletions
7
..._builder/templates/page-content/page-content--va-gov-form-builder--address-info.html.twig
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the comment here.